Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve clarity of code in kappa compiler and counter compiler #676

Merged
merged 7 commits into from
Nov 30, 2023

Conversation

antoinepouille
Copy link
Contributor

@antoinepouille antoinepouille commented Nov 27, 2023

improve readability of code, by mainly :

  • Changing multiple variable and function names
  • Adding comments for helping understanding
  • Replacing long tuples by records, adding types for data that is often shared between functions
  • Renaming Locality.annot into Loc.annoted, in all the code, to explicit the type is adding info, and not only an annotation

@antoinepouille antoinepouille changed the title Onde/first commits Improve clarity of code in kappa compiler and counter compiler Nov 27, 2023
@antoinepouille antoinepouille force-pushed the onde/first-commits branch 3 times, most recently from d3d103d to a15ab88 Compare November 30, 2023 15:19
@antoinepouille antoinepouille merged commit e01791c into master Nov 30, 2023
12 checks passed
@antoinepouille antoinepouille deleted the onde/first-commits branch November 30, 2023 16:17
antoinepouille added a commit that referenced this pull request Jan 8, 2024
* Comments, improving variable names, edit to the kasim manual

* Rename Locality.annot into Locality.annoted

* Change tuples to records in lKappa_compiler

* Refactor Signature.mli and logic to build them

* refactored assemble_rule and name_and_purify_rule

* Clarify counter_agent_info fetched from signatures with record and names

* Cleanup of counters_compiler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant